Implement easier change of bank account#94019
Conversation
…llstack-internal/Expensify-App into feat/79607-easier-change-of-bank-account
…07-easier-change-of-bank-account
…k-internal/Expensify-App into feat/79607-easier-change-of-bank-account
…07-easier-change-of-bank-account
…07-easier-change-of-bank-account
…07-easier-change-of-bank-account
…07-easier-change-of-bank-account
…07-easier-change-of-bank-account
…07-easier-change-of-bank-account
# Conflicts: # src/pages/workspace/ConnectExistingBusinessBankAccountPage.tsx
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
# Conflicts: # src/libs/actions/ReimbursementAccount/index.ts # src/pages/ReimbursementAccount/ConnectedVerifiedBankAccount.tsx # src/pages/ReimbursementAccount/ReimbursementAccountPage.tsx # src/pages/workspace/ConnectExistingBusinessBankAccountPage.tsx
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
UPD: still trying to correct the second issue. Monosnap.screencast.2026-07-15.18-07-41.mp4I'm figuring out what goes wrong |
|
I've fixed this: #94019 (comment)
Video: bug_staging.mp4This happens cause policy has one account set, and user's reimbursementAccount has another one: |
|
Hmm, interesting. In your example, if account B changes the Workspace Bank account to Bank account 2 and account A later goes back to the workflows page and taps the bank account row. Wouldn't they then see the option to link a different bank account again? It's basically the inverse scenario of what Account B originally did to change the Workspace Bank account. |
|
cc @robertjchen wdyt about this one? |
|
I agree. Seems odd to me. Discussing more here. |
Yes, it's expected that it's different. From my understanding:
So in this case, the display here should use |
|
It was agreed to fix this existing issue in a separate PR. |
|
Will recheck soon! |
|
Changes look good! |
|
🚧 robertjchen has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/robertjchen in version: 9.4.41-0 🚀
|
|
🤖 Help site changes required — draft PR created. This PR adds a user-facing Change bank account option on the connected/verified bank account screen, letting Workspace Admins and Payments Admins switch a workspace's reimbursement bank account without disconnecting the current one first. The help site's Connect a US Business Bank Account article covered connecting and linking accounts but had no coverage of switching an already-connected account, so I documented the new flow. Draft PR: #96539 What changed in the docs
@VickyStash, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Deploy Blocker #96647 was identified to be related to this PR. |
|
Deploy Blocker #96651 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.41-4 🚀
Bundle Size Analysis (Sentry): |



Explanation of Change
Workspace admins can now switch their reimbursement bank account directly from the connected/verified bank account screen, without disconnecting the current account first.
A new "Change bank account" option is added to the connected verified bank account screen. When pressed:
Fixed Issues
$ #79607
PROPOSAL: N/A
Tests
Setup: a workspace (USD) where you're an admin, and at least one business bank account already connected to your account.
1.Workflows → Payments -> Add bank account.
2. Select the account that is already set up.
Change BA → Add BA (new account) → links to workspace
Log into your bank account, proceed with the Plaid BA setup flow.Change BA → pick an existing account → links to workspace
Add partially set up bank account (add bank account, but don't provide personal info).
Change BA → pick an partially setup account
Offline tests
Same, as in Tests section
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same, as in Tests section
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_pt1.mp4
android_pt2.mp4
Android: mWeb Chrome
android_web_pt1.mp4
android_web_pt2.mp4
iOS: Native
ios_pt1.mov
ios_pt2.mov
iOS: mWeb Safari
ios_web_pt1.mov
ios_web_pt2.mov
MacOS: Chrome / Safari
web_pt1.mp4
web_pt2.mp4